rac2: return tracked deductions on close/removal #130684
Conversation
|
This change is |
kvoli
force-pushed
the
240913.rac-send-stream-close
branch
from
905173c
to
b24d692
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @kvoli)
pkg/kv/kvserver/kvflowcontrol/rac2/range_controller.go line 780 at r1 (raw file):
}() { case replicate, probeRecentlyReplicate: rs.closeSendStream(ctx)
This change is already doing part of the cleanup from #130168 which eliminated snapshot connectedState. May as well do this now, instead of leaving cruft like changeToStateSnapshot{Locked} around.
kvoli
force-pushed
the
240913.rac-send-stream-close
branch
from
b24d692
to
de91244
Compare
There was a problem hiding this comment.
TYFTR!
Reviewable status:
pkg/kv/kvserver/kvflowcontrol/rac2/range_controller.go line 780 at r1 (raw file):
Previously, sumeerbhola wrote…
This change is already doing part of the cleanup from #130168 which eliminated
snapshotconnectedState. May as well do this now, instead of leaving cruft likechangeToStateSnapshot{Locked}around.
Yeah good idea, did the snapshot cleanup and delayed stream init now.
kvoli
force-pushed
the
240913.rac-send-stream-close
branch
from
de91244
to
b62c94b
Compare
When a replica was removed from a range, or the range controller closed, any tracked deductions did not return tokens to the respective stream token counts. Update `CloseRaftMuLocked` and `SetReplicasRaftMuLocked` to close any replica send streams for replicas which are no longer part of the replica set, closing all when the range controller closes. Also immediately close the send stream when a replica transitions to StateSnapshot. Resolves: cockroachdb#130683 Release note: None
kvoli
force-pushed
the
240913.rac-send-stream-close
branch
from
b62c94b
to
0cab9b5
Compare
rm'd this function and pushed an amended the commit. |
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:
|
TYFTR! bors r=sumeerbhola |
When a replica was removed from a range, or the range controller closed, any tracked deductions did not return tokens to the respective stream token counts.
Update
CloseRaftMuLockedandSetReplicasRaftMuLockedto close any replica send streams for replicas which are no longer part of the replica set, closing all when the range controller closes.Also immediately close the send stream when a replica transitions to StateSnapshot.
Resolves: #130683
Release note: None